-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding formstate, register, setvalue + minor bug fixes #1007
Open
aranlucas
wants to merge
2
commits into
react-hook-form:master
Choose a base branch
from
aranlucas:last_docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aranlucas
commented
Jul 26, 2023
•
edited
Loading
edited
- Adding formstate, register, setvalue pages to MDX
- There were some complicated tables that stayed in html. These can be addressed or simplified in the future.
- setValue example -> sanbdox https://codesandbox.io/s/react-hook-form-v7-setvalue-h8wbk is a broken link. Didn't add in this PR
- Fixed remaining issues with docs#controller functionality to just point to the actual page instead of waiting for a redirect on /docs page. There's no more /docs#something links in code base.
- Updated dependencies which included a prettier upgrade (adding commas to the end)
- Removed some any usages by just importing API file directly.
- Added some ts-expect-errors since there's only 5 of them now and can be enabled on build
- https://react-hook-form-website-git-fork-aranlucas-lastdocs-hook-form.vercel.app/docs/useform/formstate
- https://react-hook-form-website-git-fork-aranlucas-lastdocs-hook-form.vercel.app/docs/useform/register
- https://react-hook-form-website-git-fork-aranlucas-lastdocs-hook-form.vercel.app/docs/useform/setvalue
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bluebill1049 Need help looking at logs. I think it's related to contentlayerdev/contentlayer#506 |
aranlucas
force-pushed
the
last_docs
branch
from
September 13, 2023 23:55
c8a6721
to
9a5f518
Compare
aranlucas
force-pushed
the
last_docs
branch
from
September 21, 2023 22:25
9a5f518
to
9c9b824
Compare
sorry for missing the pr review. 🙏 approved |
bluebill1049
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.